Conversation
Replace verbose membership-test idioms with the dedicated contains()
member, now available codebase-wide under C++23:
map/set/unordered_*: c.find(k) != c.end() -> c.contains(k)
c.count(k) > 0 / != 0 -> c.contains(k)
c.count(k) == 0 -> !c.contains(k)
std::string/String: s.find(x) != npos -> s.contains(x) (C++23)
647 call sites across 195 files. Conversions are restricted to provably
equivalent boolean-context forms:
- stored-iterator comparisons (auto it = m.find(k); if (it != m.end()))
are left untouched
- positional string find(x, pos) is skipped (contains has no such overload)
- count() == 1 is skipped (not equivalent for multimap/multiset)
- count() uses whose numeric value is consumed are left untouched
contains() is specified by the standard as exactly these predicates, so
there is no behavior change.
Replace .find() != .end() with .contains() for cleaner code
* Feature: make 'threads' parameter more prominent (default to max of system) and hide input/output parameters from the Param editor which are already used in the dropdown menus" of the 'Apply TOPP tool dialog' * fix typo
* git `Apply TOPP tool`, which could not find output file after the TOPP tool ran. * use correct output file type to determine annotator; always add a new layer
* fix copying of openms_thermo_bridged.dll to test folder (GENERATOR_IS_MULTI_CONFIG is a property, not a variable; needs translation) * fix to_path function (could not deal with 'ä' in Filenames); added tests * fix potential issue with single config generators on Windows (missing target_name); support all muti-config generators on Windows. No just VS
The ubuntu-arm "Create tarball" step wrote OpenMS-<ver>.tar.gz with a
relative path, i.e. into ${{ github.workspace }} -- the same directory it
archives via `-C ${{ github.workspace }} .`. As tar streamed the growing
archive into that directory, GNU tar reported "tar: .: file changed as we
read it" and exited 1, failing the step under `bash -e`. This broke the
nightly matrix deterministically (reproduced on the 2026-06-03..-06 runs).
Write the tarball to ${{ runner.temp }} (outside the workspace) and upload
it from there, so the archived directory no longer changes during the read.
Drop the now-dead self-exclude (the output is no longer in the archived tree).
Fixes OpenMS#9458
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ball fix(ci): fix nightly ARM source-tarball step (tar 'file changed as we read it')
|
@cbielow The following names might be missing from the
Please consider applying the following patch: --- AUTHORS 2026-06-08 12:44:02.149884227 +0000
+++ AUTHORS.new 2026-06-08 12:44:07.567811793 +0000
@@ -22,8 +22,9 @@
- Chirag Dave
- Chris Bauer
- Chris Bielow
- - Christie Mathews
- Christian Ehrlich
+ - Christie Mathews
+ - Claude
- Clemens Groepl
- Cornelia Friedle
- Daniel Jameson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
How can I get additional information on failed tests during CI
Click to expand
If your PR is failing you can check outIf you click in the column that lists the failed tests you will get detailed error messages.
Advanced commands (admins / reviewer only)
Click to expand
/reformat(experimental) applies the clang-format style changes as additional commit. Note: your branch must have a different name (e.g., yourrepo:feature/XYZ) than the receiving branch (e.g., OpenMS:develop). Otherwise, reformat fails to push.rebuild jenkinswill retrigger Jenkins-based CI builds