Skip to content

Tmt vis#175

Closed
cbielow wants to merge 8 commits into
developfrom
tmt_vis
Closed

Tmt vis#175
cbielow wants to merge 8 commits into
developfrom
tmt_vis

Conversation

@cbielow

@cbielow cbielow commented Jun 8, 2026

Copy link
Copy Markdown
Owner

Description

Checklist

  • Make sure that you are listed in the AUTHORS file
  • Add relevant changes and new features to the CHANGELOG file
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes
  • Updated or added python bindings for changed or new classes (Tick if no updates were necessary.)

How can I get additional information on failed tests during CI

Click to expand If your PR is failing you can check out
  • The details of the action statuses at the end of the PR or the "Checks" tab.
  • http://cdash.seqan.de/index.php?project=OpenMS and look for your PR. Use the "Show filters" capability on the top right to search for your PR number.
    If you click in the column that lists the failed tests you will get detailed error messages.

Advanced commands (admins / reviewer only)

Click to expand
  • /reformat (experimental) applies the clang-format style changes as additional commit. Note: your branch must have a different name (e.g., yourrepo:feature/XYZ) than the receiving branch (e.g., OpenMS:develop). Otherwise, reformat fails to push.
  • setting the label "NoJenkins" will skip tests for this PR on jenkins (saves resources e.g., on edits that do not affect tests)
  • commenting with rebuild jenkins will retrigger Jenkins-based CI builds

⚠️ Note: Once you opened a PR try to minimize the number of pushes to it as every push will trigger CI (automated builds and test) and is rather heavy on our infrastructure (e.g., if several pushes per day are performed).

claude and others added 8 commits June 4, 2026 17:30
Replace verbose membership-test idioms with the dedicated contains()
member, now available codebase-wide under C++23:

  map/set/unordered_*:  c.find(k) != c.end()    -> c.contains(k)
                        c.count(k) > 0 / != 0   -> c.contains(k)
                        c.count(k) == 0         -> !c.contains(k)
  std::string/String:   s.find(x) != npos       -> s.contains(x)   (C++23)

647 call sites across 195 files. Conversions are restricted to provably
equivalent boolean-context forms:
  - stored-iterator comparisons (auto it = m.find(k); if (it != m.end()))
    are left untouched
  - positional string find(x, pos) is skipped (contains has no such overload)
  - count() == 1 is skipped (not equivalent for multimap/multiset)
  - count() uses whose numeric value is consumed are left untouched

contains() is specified by the standard as exactly these predicates, so
there is no behavior change.
Replace .find() != .end() with .contains() for cleaner code
* Feature: make 'threads' parameter more prominent (default to max of system) and hide input/output parameters from the Param editor  which are already used in the dropdown menus" of the 'Apply TOPP tool dialog'

* fix typo
* git `Apply TOPP tool`, which could not find output file after the TOPP tool ran.

* use correct output file type to determine annotator; always add a new layer
* fix copying of openms_thermo_bridged.dll to test folder (GENERATOR_IS_MULTI_CONFIG is a property, not a variable; needs translation)

* fix to_path function (could not deal with 'ä' in Filenames); added tests

* fix potential issue with single config generators on Windows (missing target_name); support all muti-config generators on Windows. No just VS
The ubuntu-arm "Create tarball" step wrote OpenMS-<ver>.tar.gz with a
relative path, i.e. into ${{ github.workspace }} -- the same directory it
archives via `-C ${{ github.workspace }} .`. As tar streamed the growing
archive into that directory, GNU tar reported "tar: .: file changed as we
read it" and exited 1, failing the step under `bash -e`. This broke the
nightly matrix deterministically (reproduced on the 2026-06-03..-06 runs).

Write the tarball to ${{ runner.temp }} (outside the workspace) and upload
it from there, so the archived directory no longer changes during the read.
Drop the now-dead self-exclude (the output is no longer in the archived tree).

Fixes OpenMS#9458

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ball

fix(ci): fix nightly ARM source-tarball step (tar 'file changed as we read it')
@cbielow cbielow closed this Jun 8, 2026
@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

@cbielow The following names might be missing from the AUTHORS file:

  • Chris Bielow

Please consider applying the following patch:

--- AUTHORS	2026-06-08 12:44:02.149884227 +0000
+++ AUTHORS.new	2026-06-08 12:44:07.567811793 +0000
@@ -22,8 +22,9 @@
  - Chirag Dave
  - Chris Bauer
  - Chris Bielow
- - Christie Mathews
  - Christian Ehrlich
+ - Christie Mathews
+ - Claude
  - Clemens Groepl
  - Cornelia Friedle
  - Daniel Jameson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants